Nerf necropolis' spellbooks

[kyunkyunkyun]

Что этот PR делает

Удаляет возможность заспавнить книгу майндсвапа в Некрополе.

Почему это хорошо для игры

Потому что она ничего хорошего в раунд не привносит. Сам спавнер изначально был добавлен модульно, но взят с оффов, а на оффах он в руинах не используется, следовательно не балансно!!!

Тестирование

запустил локалочку и заспавнил кучу /obj/item/spellbook/oneuse/random/necropolis.

Changelog

🆑
tweak: В Некрополе больше нельзя найти книгу майндсвапа.
/:cl:

Summary by Sourcery

Tests:

• Tested spawning multiple Necropolis spellbooks in a local environment.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the mindswap spellbook from the Necropolis random spellbook spawn pool. This change aims to improve game balance by preventing the mindswap spellbook, which is not intended to spawn in ruins on the main codebase, from appearing in the Necropolis.

Class diagram for spellbook inheritance and banned types

classDiagram
    class SpellbookOneuse {
        <<abstract>>
    }
    class RandomNecropolis {
        +initialize()
        -banned_spells: list
    }
    class MimeSpellbook
    class EMPSpellbook
    class MindswapSpellbook
    SpellbookOneuse <|-- RandomNecropolis
    SpellbookOneuse <|-- MimeSpellbook
    SpellbookOneuse <|-- EMPSpellbook
    SpellbookOneuse <|-- MindswapSpellbook
    note for RandomNecropolis "Now excludes Mindswap,
Mime, and EMP spellbooks"

Loading

Flow diagram for updated Necropolis spellbook spawning

graph TD
    A[Random Necropolis Spellbook] --> B{Initialize}
    B --> C[Get banned spells list]
    C --> D[Mime spells]
    C --> E[EMP spells]
    C --> F[Mindswap spells]
    B --> G[Pick random spell type]
    G --> H{Is spell type banned?}
    H -->|Yes| G
    H -->|No| I[Spawn selected spellbook]
    I --> J[Delete original random book]

Loading

File-Level Changes

Change	Details	Files
Removed mindswap spellbook from the Necropolis spellbook spawn pool.	Ensured that the mindswap spellbook is excluded from the random selection of spellbooks spawned in the Necropolis.	modular_ss220/objects/code/spellbook.dm
Updated map files to reflect the removal of the mindswap spellbook.	Modified map files to align with the updated spellbook spawning logic. Removed the mindswap spellbook from the Necropolis spellbook spawn pool.	_maps/map_files220/generic/Lavaland.dmm modular_ss220/objects/_objects.dme

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.