Разблокировка BPM музыкальных инструментов #1585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Частичная модульность
|
Почему не на оффы? |
Попробовать в виде ТМа, да и самому чет страшненько туда что-либо отправлять |
|
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord. |
github-actions
bot
added
the
Stale
|
This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Частичная модульность
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Переопределяет функции, отвечающие за настройку темпа при воспроизведении треков с музыкальных инстурментов.
В данный момент она расчитывается по формуле:
600 / X = BPM, где X - значение задержки, и имеет шаг в 0.5, что достаточно жестко лочит BPM.
Почему это хорошо для игры
Музыка (в идеале) будет звучать ближе к оригиналу midi с которого она взята.
Изображения изменений
Тестирование
Тестирование на локале
Changelog
🆑
tweak: Снятие шаговой блокировки BPM для музыкальных инструментов.
/:cl: