Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: vending.dm #6174

Merged
merged 26 commits into from
Dec 5, 2024
Merged

translation: vending.dm #6174

merged 26 commits into from
Dec 5, 2024

Conversation

anon1mka
Copy link
Contributor

@anon1mka anon1mka commented Nov 14, 2024 •
edited
Loading

Описание

Перевод описаний, слоганов, взаимодействия и всего что связано с вендоматами.

Ссылка на предложение/Причина создания ПР

По запросу Заза Лорда

Демонстрация изменений

1
2
3
4

Тесты

Тестил на локалке. Вроде работает 🤡

@anon1mka
Update MegaSeed Servitor RU
5a92f85 
Перевод слоганов TTS для MegaSeed Servitor.
@anon1mka
Update MegaSeed Servitor RU
cb4b4a5
@anon1mka
Updatge vending.dm
cb551f5 
Перевод текста, замена to_chat на ballon_alert'ы
@anon1mka anon1mka changed the title translation: MegaSeed Servitor translation: vending.dm Nov 14, 2024
@anon1mka anon1mka marked this pull request as draft November 14, 2024 07:03
PlayerUnknown14
PlayerUnknown14 reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@PlayerUnknown14 PlayerUnknown14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Настоятельно рекомендую ознакомиться.

code/game/machinery/vending.dm Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Show resolved Hide resolved
paradise.dme Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Show resolved Hide resolved
@pilygun pilygun added the перевод Съешь же ещё этих мягких французских булок, да выпей чаю label Nov 14, 2024
@anon1mka anon1mka marked this pull request as ready for review November 14, 2024 18:14
PlayerUnknown14
PlayerUnknown14 reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@PlayerUnknown14 PlayerUnknown14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит уже много лучше, кроме пары микро-моментов. Если их не учитывать, то можно уже заливать. Мне нравится, маладца.

code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Show resolved Hide resolved
PlayerUnknown14
PlayerUnknown14 reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@PlayerUnknown14 PlayerUnknown14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Быстро пробежался, минусов не заметил. Даю добро.

PlayerUnknown14
PlayerUnknown14 reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@PlayerUnknown14 PlayerUnknown14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

изображение_2024-11-17_122802156

pilygun
pilygun previously approved these changes Nov 18, 2024
View reviewed changes
@pilygun pilygun added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Nov 21, 2024
Antoonij
Antoonij reviewed Nov 21, 2024
View reviewed changes
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
Antoonij
Antoonij reviewed Nov 22, 2024
View reviewed changes
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
code/game/machinery/vending.dm Outdated Show resolved Hide resolved
@anon1mka anon1mka requested review from Antoonij and pilygun November 25, 2024 01:45
pilygun
pilygun previously approved these changes Dec 3, 2024
View reviewed changes
Antoonij
Antoonij approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Antoonij Antoonij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Теперь выглядит хорошо

@pilygun pilygun added this pull request to the merge queue Dec 5, 2024
Merged via the queue into ss220-space:master220 with commit a5f07fa Dec 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlayerUnknown14 PlayerUnknown14 PlayerUnknown14 left review comments

@Antoonij Antoonij Antoonij approved these changes

@pilygun pilygun pilygun approved these changes

@Vladisvell Vladisvell Awaiting requested review from Vladisvell

Assignees

@pilygun pilygun

Labels
Has Approve Have been approved by somebody from Review Team and awaiting for one more approve перевод Съешь же ещё этих мягких французских булок, да выпей чаю
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anon1mka @pilygun @Antoonij @PlayerUnknown14