-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: You can now set up preference for removing from round #6069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Den109G
reviewed
Oct 26, 2024
Den109G
reviewed
Oct 26, 2024
Co-authored-by: Den109G <[email protected]>
Daeberdir
reviewed
Oct 26, 2024
Co-authored-by: Daeberdir <[email protected]>
Daeberdir
reviewed
Oct 26, 2024
Daeberdir
previously approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Допустим. Пойдёт.
Но я напомню, что все видят названия коммитов. |
Daeberdir
added
the
Has Approve
Have been approved by somebody from Review Team and awaiting for one more approve
label
Oct 26, 2024
Antoonij
requested changes
Nov 2, 2024
@Daeberdir |
Antoonij
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vladisvell
changed the title
add: "gib me please" set up
add: You can now set up preference for removing from round
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Has Approve
Have been approved by somebody from Review Team and awaiting for one more approve
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавление настройки которая разрешает выводить вас из раунда без соответствующей цели. Инфа об этом видна при осмотре. Сделал чтоб это было видно только у людей и только при наличии assigned_role (т.е. без всяких макак и эшей). Переключение настройки логируется.
Ссылка на предложение
https://discord.com/channels/617003227182792704/755125334097133628/1298696519465172993
Тесты
Ну, запустил, поосматривал куклу с разным состоянием этой настройки.