Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: You can now set up preference for removing from round #6069

Merged
merged 9 commits into from
Nov 2, 2024

Conversation

Anorak2024
Copy link
Contributor

Описание

Добавление настройки которая разрешает выводить вас из раунда без соответствующей цели. Инфа об этом видна при осмотре. Сделал чтоб это было видно только у людей и только при наличии assigned_role (т.е. без всяких макак и эшей). Переключение настройки логируется.

Ссылка на предложение

https://discord.com/channels/617003227182792704/755125334097133628/1298696519465172993

Тесты

Ну, запустил, поосматривал куклу с разным состоянием этой настройки.

@Anorak2024 Anorak2024 requested a review from Den109G October 26, 2024 06:27
code/__DEFINES/preferences.dm Outdated Show resolved Hide resolved
code/__DEFINES/preferences.dm Outdated Show resolved Hide resolved
code/modules/client/preference/preferences_toggles.dm Outdated Show resolved Hide resolved
Daeberdir
Daeberdir previously approved these changes Oct 26, 2024
Copy link
Member

@Daeberdir Daeberdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Допустим. Пойдёт.

@Daeberdir
Copy link
Member

Но я напомню, что все видят названия коммитов.

@Daeberdir Daeberdir added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Oct 26, 2024
@Anorak2024
Copy link
Contributor Author

@Daeberdir
Сделал чтоб видели только антаги

Copy link
Contributor

@Antoonij Antoonij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Вот теперь выглядит хорошо.

@Vladisvell Vladisvell changed the title add: "gib me please" set up add: You can now set up preference for removing from round Nov 2, 2024
@Vladisvell Vladisvell added this pull request to the merge queue Nov 2, 2024
Merged via the queue into ss220-space:master220 with commit d576a6e Nov 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Approve Have been approved by somebody from Review Team and awaiting for one more approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants