Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: New map voting mode "Notriples" - next map can't be selected if played twice in a row #5452

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

Vladisvell
Copy link
Collaborator

Описание

[Second, Vega, Cleo]
PR добавляет в игру новый режим выбора карт, позволяющий играть две карты подряд, однако на третий раз эту же карту в голосовании выбрать нельзя.

Ссылка на предложение/Причина создания ПР

https://discord.com/channels/617003227182792704/755125334097133628/1259994700970987540

@Vladisvell Vladisvell requested a review from Bizzonium as a code owner July 14, 2024 11:16
@Vladisvell Vladisvell added the SQL PR changes SQL operations or database structure label Oct 11, 2024
NightDawnFox
NightDawnFox previously approved these changes Oct 14, 2024
Copy link
Contributor

@NightDawnFox NightDawnFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надеюсь ты знаешь что делаешь

Daeberdir
Daeberdir previously approved these changes Oct 14, 2024
@Vladisvell Vladisvell dismissed stale reviews from Daeberdir and NightDawnFox via 31daa04 October 14, 2024 15:45
Copy link
Contributor

@Den109G Den109G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит хорошо со стороны кода. Даже есть проверка на существование previous_maps

@Den109G Den109G added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Oct 16, 2024
@Bizzonium Bizzonium merged commit c382513 into ss220-space:master220 Oct 18, 2024
12 checks passed
@Vladisvell Vladisvell deleted the doubles-doubles branch October 18, 2024 18:21
@Daeberdir Daeberdir removed the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL PR changes SQL operations or database structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants