refactor: (?) simple replacement slot_l_hand -> SLOT_HUD_LEFT_HAND etc #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Merge Conflict
Rerik007
force-pushed
the
simple-change-smallletter-define
branch
from
af2b78a to
9a2247d
Compare
github-actions
bot
added
Merge Conflict
github-actions
bot
added
Merge Conflict
Gottfrei
previously approved these changes
Mar 12, 2024
Rerik007
force-pushed
the
simple-change-smallletter-define
branch
from
cfd786d to
f32b22f
Compare
Gottfrei
previously approved these changes
Mar 12, 2024
Gottfrei
previously approved these changes
Mar 21, 2024
github-actions
bot
added
Merge Conflict
Gottfrei
previously approved these changes
Mar 26, 2024
Gottfrei
previously approved these changes
Mar 28, 2024
Rerik007
force-pushed
the
simple-change-smallletter-define
branch
from
6048595 to
c7f8d32
Compare
Bizzonium
force-pushed
the
simple-change-smallletter-define
branch
from
c7f8d32 to
05c1b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Изменяет дефайны номера слота со строчных на все прописные (тоесть например slot_s_store это теперь SLOT_HUD_SUIT_STORE), как и должны быть все дефайны. Мне также пришлось изменить битфлаговые дефайны слотоа, поскольку некоторые из них были одинаковыми, но только в верхнем регистре. Я изменил их все на SLOT_FLAG_... для согласованности.
Сделано простой заменой.
Этот пр достаточно конфликтный, потому что эти флаги используются много где. Некоторые пры могут быть сломаны, однако это решается достаточно легко, главное увидеть что пр такой.
Ссылка на предложение/Причина создания ПР
Эти дефайны со строчными буквами путали меня. Дефайны должны быть написаны прописными буквами, переменные строчными.