add/refactor: Chameleon Rework (#5065)

Chameleon Rework

code/datums/outfits/outfit.dm

@@ -148,6 +148,14 @@
 	H.regenerate_icons()
 	return TRUE
 
+
+/datum/outfit/proc/get_chameleon_disguise_info()
+	var/list/types = list(uniform, suit, back, belt, gloves, shoes, head, mask, neck, l_ear, r_ear, glasses, id, l_pocket, r_pocket, suit_store, r_hand, l_hand, pda)
+	types += chameleon_extras
+	listclearnulls(types)
+	return types
+
+
 /datum/outfit/proc/apply_fingerprints(mob/living/carbon/human/H)
 	if(!istype(H))
 		return

code/game/jobs/job/job.dm

@@ -285,13 +285,15 @@
 		PDA.ownrank = C.rank
 		PDA.name = "PDA-[H.real_name] ([PDA.ownjob])"
 
-/datum/outfit/job/proc/get_chameleon_disguise_info()
-	var/on_back = (allow_backbag_choice) ? backpack : back
-	var/list/types = list(uniform, suit, on_back, belt, gloves, shoes, head, mask, neck, l_ear, r_ear, glasses, id, l_pocket, r_pocket, suit_store, r_hand, l_hand, pda)
-	types += chameleon_extras
-	listclearnulls(types)
+
+/datum/outfit/job/get_chameleon_disguise_info()
+	var/list/types = ..()
+	if(allow_backbag_choice && backpack)
+		types -= back
+		types += backpack
 	return types
 
+
 /datum/job/proc/would_accept_job_transfer_from_player(mob/player)
 	if(!transfer_allowed)
 		return FALSE

code/game/objects/items/devices/voice.dm

@@ -30,14 +30,19 @@
 
 /obj/item/voice_changer/attack_self(mob/user)
 	active = !active
-	icon_state = "voice_changer_[active ? "on" : "off"]"
+	update_icon(UPDATE_ICON_STATE)
 	if(inform_about_toggle)
 		to_chat(user, span_notice("You toggle [src] [active ? "on" : "off"]."))
 
 	for(var/X in actions)
 		var/datum/action/A = X
 		A.UpdateButtonIcon()
 
+
+/obj/item/voice_changer/update_icon_state()
+	icon_state = "voice_changer_[active ? "on" : "off"]"
+
+
 /obj/item/voice_changer/proc/set_voice(mob/user)
 	var/mimic_voice
 	var/mimic_voice_tts