Skip to content

Commit

Permalink
reverts click_catcher "fix" for clicking at space tiles
Browse files Browse the repository at this point in the history
  • Loading branch information
BeebBeebBoob committed Oct 25, 2024
1 parent 4ab59d7 commit 88bf0cf
Showing 1 changed file with 6 additions and 14 deletions.
20 changes: 6 additions & 14 deletions code/_onclick/click.dm
Original file line number Diff line number Diff line change
Expand Up @@ -471,21 +471,13 @@

/atom/movable/screen/click_catcher/Initialize(mapload, datum/hud/hud_owner)
. = ..()
var/client/boss = hud_owner?.mymob?.canon_client
if(!boss)
return
var/static/list/connections = list(
COMSIG_MOVABLE_Z_CHANGED = PROC_REF(on_z_change),
)

// I fucking hate this.
// So, hear me out. Due to how planes now work, on multiz server the clickcatcher can cause troubles to ones who on upper planes.
// The 'offset_increased' "should" fixed that but it didn't.
// The bug is when you on the upper floor(or single-level z-level) and you try interact with space. It fucks up due to clickcatcher somehow OVERLAPS
// Even though it's on the lowest plane ever. I don't know why and I don't want to know how, but this is the least I can do. I'm not sorry either.
/atom/movable/screen/click_catcher/proc/on_z_change(mob/source)
RegisterSignal(SSmapping, COMSIG_PLANE_OFFSET_INCREASE, PROC_REF(offset_increased))
offset_increased(SSmapping, 0, SSmapping.max_plane_offset)

// Draw to the lowest plane level offered
/atom/movable/screen/click_catcher/proc/offset_increased(datum/source, old_offset, new_offset)
SIGNAL_HANDLER
SET_PLANE(src, PLANE_TO_TRUE(src.plane), source)
SET_PLANE_W_SCALAR(src, initial(plane), new_offset)

/atom/movable/screen/click_catcher/Click(location, control, params)
var/list/modifiers = params2list(params)
Expand Down

0 comments on commit 88bf0cf

Please sign in to comment.