Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDA messaging Port #245

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Conversation

Ermucat
Copy link

@Ermucat Ermucat commented Dec 25, 2024

About the PR

Added the new app Nanochat, allowing crewmembers to chat if given their nanochat ID
Port of DeltaV-Station/Delta-v#2362 so props to them

Why / Balance

This gives traitors a new way of exchanging information instead of just sitting a corner, adds depth, and potential to be utilized

Technical details

Changed LogProbe UI and system
Changed Agent ID UI and system
Added DeltaV folders for Content.Server,Content.Client,Content.Shared
Added new nanochat ui
Added new nanochat system
added new nanochat components

Media

2024-12-25.12-35-23.mp4

Requirements

Breaking changes

Changelog

🆑

  • add: Added a new program to your pda, nanochat!

Copy link

github-actions bot commented Dec 25, 2024

RSI Diff Bot; head commit 363c024 merging into 268d836
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DeltaV/Misc/program_icons.rsi

State Old New Status
nanochat Added

Resources/Textures/_DeltaV/Objects/Devices/cartridge.rsi

State Old New Status
cart-chat Added

Edit: diff updated after 363c024

Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After first quick glance:

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Dec 25, 2024
@FluffMe
Copy link
Collaborator

FluffMe commented Dec 25, 2024

FYI, you can run the tests locally, not on github. So that you can fix everything before you push and be mostly sure that it's fixed.

The command to run the test is listed in the test: https://github.com/ss14-harmony/space-station-14/actions/runs/12495369896/job/34869788588#step:10:3 on the example of Integration tests.

Currently even Build fails, so please test changes before pushing them.

@Ermucat Ermucat requested a review from FluffMe December 25, 2024 23:53
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Dec 25, 2024
This reverts commit ea7cc2e.
Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the review popped again, but:

  • Linter fails
  • Build fails
  • Tests fail

It got worse. Please fix before requesting review.

I am drafting this. Please undraft when it's in ready and test passing state.

DieselMohawk
DieselMohawk previously approved these changes Jan 5, 2025
Copy link
Collaborator

@DieselMohawk DieselMohawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites look good.

Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has a mix of DeltaV namespaces (DeltaV and _DeltaV) in this PR that should be addressed.
DeltaV namespaces on harmony are _DeltaV and soon to be changed in bulk.

Please change all instances of Content.Client.DeltaV... Content.Shared.DeltaV... Content.Client.DeltaV... etc to Content.Client._DeltaV... Content.Shared._DeltaV... Content.Client._DeltaV... etc for an easier bulk change in the upcoming PR.

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested S: DO NOT MERGE labels Jan 6, 2025
@FluffMe
Copy link
Collaborator

FluffMe commented Jan 6, 2025

Additionally, consider implementing this DeltaV-Station/Delta-v#2565 and any other changes that followed the initial PR

@Ermucat Ermucat requested a review from FluffMe January 6, 2025 16:36
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Jan 6, 2025
Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FluffMe FluffMe added S: Merge Conflict Merge conflict detected S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Jan 7, 2025
@github-actions github-actions bot removed the S: Merge Conflict Merge conflict detected label Jan 7, 2025
@Ermucat Ermucat requested a review from FluffMe January 7, 2025 15:49
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants