-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDA messaging Port #245
base: master
Are you sure you want to change the base?
PDA messaging Port #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After first quick glance:
- Test fail is real: https://github.com/ss14-harmony/space-station-14/actions/runs/12495369896/job/34869788588?pr=245#step:10:15
Please fix it - All
DeltaV
folders should be_DeltaV
instead
FYI, you can run the tests locally, not on github. So that you can fix everything before you push and be mostly sure that it's fixed. The command to run the test is listed in the test: https://github.com/ss14-harmony/space-station-14/actions/runs/12495369896/job/34869788588#step:10:3 on the example of Integration tests. Currently even Build fails, so please test changes before pushing them. |
This reverts commit 69d7351.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the review popped again, but:
- Linter fails
- Build fails
- Tests fail
It got worse. Please fix before requesting review.
I am drafting this. Please undraft when it's in ready and test passing state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprites look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR has a mix of DeltaV namespaces (DeltaV
and _DeltaV
) in this PR that should be addressed.
DeltaV namespaces on harmony are _DeltaV
and soon to be changed in bulk.
Please change all instances of Content.Client.DeltaV...
Content.Shared.DeltaV...
Content.Client.DeltaV...
etc to Content.Client._DeltaV...
Content.Shared._DeltaV...
Content.Client._DeltaV...
etc for an easier bulk change in the upcoming PR.
Additionally, consider implementing this DeltaV-Station/Delta-v#2565 and any other changes that followed the initial PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Unresolved merge conflict
- Please implement make nanochat notifications more robust DeltaV-Station/Delta-v#2565
Signed-off-by: Ermucat <[email protected]>
About the PR
Added the new app Nanochat, allowing crewmembers to chat if given their nanochat ID
Port of DeltaV-Station/Delta-v#2362 so props to them
Why / Balance
This gives traitors a new way of exchanging information instead of just sitting a corner, adds depth, and potential to be utilized
Technical details
Changed LogProbe UI and system
Changed Agent ID UI and system
Added DeltaV folders for Content.Server,Content.Client,Content.Shared
Added new nanochat ui
Added new nanochat system
added new nanochat components
Media
2024-12-25.12-35-23.mp4
Requirements
Breaking changes
Changelog
🆑