Fix MS Graph Group Sync

Fix group parsing to only run on returned Group objects as the Graph call was also returning directory roles and admin units. re: hkamel#120
srvrguy · Dec 6, 2022 · ba272cf · ba272cf
1 parent 5ca09fd
commit ba272cf
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/main/java/org/almrangers/auth/aad/AadUserInfo.java b/src/main/java/org/almrangers/auth/aad/AadUserInfo.java
@@ -174,12 +174,14 @@ Set<String> processMemberGroupCollection(@Nullable DirectoryObjectCollectionWith
         while(memberGroupCollection != null) {
             final List<DirectoryObject> groupList = memberGroupCollection.getCurrentPage();
 
-            for ( DirectoryObject group : groupList) {
-                String groupDisplayName = ((Group) group).displayName;
-
-                // Don't add the group if the display name is null
-                if(groupDisplayName != null) {
-                    parsedUserGroups.add(groupDisplayName);
+            for (DirectoryObject group : groupList) {
+                if (group instanceof Group) {
+                    String groupDisplayName = ((Group) group).displayName;
+
+                    // Don't add the group if the display name is null
+                    if (groupDisplayName != null) {
+                        parsedUserGroups.add(groupDisplayName);
+                    }
                 }
             }