Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for user supplied coverage output types #94

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

R9295
Copy link
Collaborator

@R9295 R9295 commented Jun 14, 2024

No description provided.

@R9295
Copy link
Collaborator Author

R9295 commented Jun 14, 2024

There's a strange error that needs to be fixed

11:11:34 [ERROR] A panic occurred at .../grcov-0.8.19/src/main.rs:487: output_path must be a directory when using multiple outputs

@vanhauser-thc
Copy link
Collaborator

But that error has nothing to do with your pr right?

@R9295
Copy link
Collaborator Author

R9295 commented Jun 17, 2024

@vanhauser-thc you're right, it doesn't. I guess lcov and html don't play well together since lcov is a file and html wants a dir. Could you merge please?

@vanhauser-thc vanhauser-thc merged commit f364a3a into srlabs:main Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants