-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a new snow interception module and fixed segfault issue when running crhm-cli #462
Open
acebulsk
wants to merge
16
commits into
srlabUsask:master
Choose a base branch
from
acebulsk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pears to work using new files w old algorithm now to modify.
…x canopy snow load for sublimation to constant
…ltwater unloading switch
…ding switch. now we are getting exactly the same as before adding the switches
…n startdate equaled the first obs date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new snow interception module
CanopyVectorBased
has been added which is described in detail in the manuscript which has been submitted to the Hydrological Processes journal (Cebulski & Pomeroy) available here.General Description of
CanopyVectorBased
A
switch
parameter set in the prj file controls the ablation parameterization used in theCanopyVectorBased
module:SublimationSwitch
== 1 turns on canopy snow sublimation using Pomeroy et al., (1998)SublimationSwitch
== 0 turns off sublimation of canopy snow for testingMassUnloadingSwitch
== 0 is the mass unloading portion of the latest iteration of the Hedstrom & Pomeroy 1998 unloading with modifications by Ellis et al. (2010) and Floyd (2012)MassUnloadingSwitch
== 1 are the new ablation parameterisations developed at fortress mountain based on wind speed, duration, and air temperature.TODO
CLASS
or the existing CRHM modulePSPnew
which currently does not workOther Important Changes
#460 appears to be resolved for now.