Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace table writer with go-pretty #2292 #2296

Merged
merged 19 commits into from
Nov 25, 2024

change style for the netem table

5d66ede
Select commit
Loading
Failed to load commit list.
Merged

replace table writer with go-pretty #2292 #2296

change style for the netem table
5d66ede
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2024 in 1s

51.39% (+0.80%) compared to d442919

View this Pull Request on Codecov

51.39% (+0.80%) compared to d442919

Details

Codecov Report

Attention: Patch coverage is 79.76190% with 17 lines in your changes missing coverage. Please review.

Project coverage is 51.39%. Comparing base (d442919) to head (5d66ede).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/inspect.go 77.27% 11 Missing and 4 partials ⚠️
runtime/docker/firewall/iptables/client.go 0.00% 1 Missing ⚠️
runtime/docker/firewall/nftables/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
+ Coverage   50.59%   51.39%   +0.80%     
==========================================
  Files         172      172              
  Lines       16770    16830      +60     
==========================================
+ Hits         8484     8649     +165     
+ Misses       7369     7257     -112     
- Partials      917      924       +7     
Files with missing lines Coverage Δ
cmd/tools_netem.go 70.29% <100.00%> (+0.90%) ⬆️
runtime/docker/firewall/iptables/client.go 0.00% <0.00%> (ø)
runtime/docker/firewall/nftables/client.go 71.16% <0.00%> (+3.32%) ⬆️
cmd/inspect.go 76.60% <77.27%> (-2.61%) ⬇️

... and 6 files with indirect coverage changes

---- 🚨 Try these New Features: