New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Wrogn template is used when two different model families used for chat and autocomplete #42

Open

ldeninski wants to merge 1 commit into srikanth235:master from ldeninski:bugfix/wrong-template-used-when-two-models-used-for-chat-and-autocomplete

ldeninski commented May 14, 2024

This PR:

Changes the feature argument in AiClient.getModel to be a enum (or a valid string in it)
Removes the default argument value to avoid future bugs
Adds some usefull typing utils
Fixes the bug in AutoCompleteProvider.provideInlineCompletionItems where AIClient.getModel is called without an argument causing it to default to the chat model thus breaking autocomplete when the model families for chat and autocomplete are different


          switched to enum for feature param in AiClient.getModel and removed…

a105e2e

… default param value to avoid future bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet