♻️ Refactor the repository interfaces and implementations to d… #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the interdepencency among classes.
dogukan10
reviewed
Nov 27, 2024
tofhir-common/src/main/scala/io/tofhir/common/model/ICachedRepository.scala
Outdated
Show resolved
Hide resolved
tofhir-server/src/main/scala/io/tofhir/server/endpoint/ToFhirServerEndpoint.scala
Outdated
Show resolved
Hide resolved
tofhir-server/src/main/scala/io/tofhir/server/endpoint/ToFhirServerEndpoint.scala
Outdated
Show resolved
Hide resolved
tofhir-server/src/main/scala/io/tofhir/server/repository/schema/ISchemaRepository.scala
Outdated
Show resolved
Hide resolved
… achieve separation of cocerns and and make it the single responsible for the repositories required by the services.
dogukan10
approved these changes
Nov 28, 2024
YemreGurses
reviewed
Nov 28, 2024
This is a good suggestion. I would prefer implementing such a refactoring in another effort/branch after completing this. |
…onalities. toFHIR-Web can retrieve the list of related environment variables and the values through /metadata endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecrease the interdepencency among classes.