fix: update to latest kotlin-editor and don't delete complex statements in dependencies blocks. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in dependencies blocks.
autonomousapps
commented
Nov 5, 2024
Comment on lines
+244
to
+258
| val complex = "a:complex:$expression" | ||
|
|
||
| if (org.apache.tools.ant.taskdefs.condition.Os.isArch("aarch64")) { | ||
| // Multi-line comment about why we're | ||
| // doing this. | ||
| testImplementation("io.github.ganadist.sqlite4java:libsqlite4java-osx-aarch64:1.0.392") | ||
| } | ||
|
|
||
| add("extraImplementation", libs.a) | ||
|
|
||
| api(libs.d) | ||
|
|
||
| implementation(complex) | ||
|
|
||
| testImplementation("g:e:1") |
There was a problem hiding this comment.
I think this ordering could be improved further. We can probably specially parse the add(...) expression, and maybe also ensure that property expressions are modeled as such and always at top, rather than at top by accident. The if-expression is more complex, and arguably an anti-pattern, so I think we'll just leave that alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cashapp/kotlin-editor#16