Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to disable blank lines between configurations #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonapoul
Copy link

@jonapoul jonapoul commented Aug 2, 2024

Basically, this adds a flag to the CLI tool and the Gradle plugin to disable auto-insertion of blank lines between blocks of different configurations. So currently it will generate something like:

dependencies {
  api(libs.a)
  api(libs.b)

  implementation(libs.c)

  testImplementation(libs.d)
  testImplementation(libs.e)
}

When this flag is set to false, you get:

dependencies {
  api(libs.a)
  api(libs.b)
  implementation(libs.c)
  testImplementation(libs.d)
  testImplementation(libs.e)
}

as in the test cases. Yes I realise this is petty - I just prefer it without blank lines 🙂

I'm not 100% sure on the double-negativity of the CLI flag - any feedback/suggestions on that is welcome.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

@jonapoul jonapoul marked this pull request as ready for review August 2, 2024 10:35
@jonapoul jonapoul force-pushed the jp/skip-hidden-and-build-dirs branch from fba8f1d to 08e5724 Compare October 13, 2024 19:42
@jonapoul
Copy link
Author

jonapoul commented Oct 13, 2024

I'm getting a test failure for the can check sort order case in FunctionalSpec after rebasing, but I get the same thing on main too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants