Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Fix up a case where we report errors poorly when state is wrong, usually... #428

Merged
merged 2 commits into from
Aug 1, 2014

Conversation

cgruber
Copy link
Collaborator

@cgruber cgruber commented Aug 1, 2014

... becuase of inconsistency in what is passed in to ObjectGraph.create().

…lly becuase of inconsistency in what is passed in to ObjectGraph.create().
@cgruber
Copy link
Collaborator Author

cgruber commented Aug 1, 2014

Yeah 2.0 and all that, but this might help people debug, so it is probably worth rolling a 1.2.x at some point.

@JakeWharton
Copy link
Collaborator

Yeah there's a few tiny fixes to the 1.x stuff I'd like to make. Made a
pass over the issues last weekend.
On Aug 1, 2014 9:29 AM, "Christian Edward Gruber" [email protected]
wrote:

Yeah 2.0 and all that, but this might help people debug, so it is probably
worth rolling a 1.2.x at some point.


Reply to this email directly or view it on GitHub
#428 (comment).

JakeWharton added a commit that referenced this pull request Aug 1, 2014
Fix up a case where we report errors poorly when state is wrong, usually...
@JakeWharton JakeWharton merged commit ed5c936 into square:master Aug 1, 2014
@cgruber
Copy link
Collaborator Author

cgruber commented Aug 1, 2014

Hmm. The build is breaking. :(

@JakeWharton
Copy link
Collaborator

I added JDK 8 recently. See #425.

@cgruber
Copy link
Collaborator Author

cgruber commented Aug 1, 2014

Oh. Sorry - missed that. I had it in a branch locally but wasn't going to add it until i'd fixed the issues. :/ Ok. If you're satisfied - it does seem to be a failure in an unrelated invoker test.

@JakeWharton
Copy link
Collaborator

Yep. And the build passed on Oracle JDK 7 and OpenJDK 7

@cgruber
Copy link
Collaborator Author

cgruber commented Aug 1, 2014

Gotcha. Cool cool.

@cgruber cgruber deleted the improvederror branch August 1, 2014 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants