Round up measurements of fixed-size stack child elements #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without rounding up the measured size of
Stack
's fixed-size child elements, rounding errors and/or floating representations can result in layout issues with a child that should almost exactly fit in a stack, and these children are not being snapped to pixel edges.This can be seen it in the added unit test. Consider this row:
When laid out on an
@2x
device, without the fix:After the fix, the row still has a width of 161, and: