Add passThroughTouches to BlueprintView, PassthroughView #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watt
approved these changes
Sep 17, 2024
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Changed | |||
|
|
|||
| - Moved `CornerStyle` out of the `Box` namespace, and is now a root type in `BlueprintUICommonControls`. `Box.CornerStyle` is still available as a typealias. | |||
| - `BlueprintView` will now pass through touches to views lower in the view hierarchy if `passThroughTouches` is true. | |||
There was a problem hiding this comment.
this is a non-breaking addition, right?
There was a problem hiding this comment.
Ahh yep, good catch. I'd originally just made this the only behavior, but figured that was a bad idea.
- Fix Changelog
kyleve
commented
Sep 17, 2024
ldstreet
approved these changes
Sep 18, 2024
maxg-square
added a commit
that referenced
this pull request
Nov 4, 2024
* tag '4.3.0': Prepare version 4.3.0 (#513) Add passThroughTouches to BlueprintView, PassthroughView (#511) Bump checkout and upload-artifacts (#512) Bump rexml from 3.2.8 to 3.3.6 Unnest Box.CornerStyle (#508) Prepare 4.2.1 (#507) Make public the UIBezierPath helper using Box.CornerStyle Prepare 4.2.0 (#505) Label and AttributedLabel now support accessibilityValue (#504) Prepare 4.1.2 Release (#503) Replace newlines in a11y labels with spaces (#502) Fix string index out of bounds crash. (#501) bumping version to 4.1.0 (#499) AttributedLabel Link Accessibility (#459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Blueprint will eat any touches that are meant for views behind it – in particular relevant if you're layering them in the z-index and the one on "top" is largely visually transparent.
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-09-17.at.14.50.16.mp4