Replace newlines in a11y labels with spaces #502
Conversation
| return label | ||
|
|
||
| // We need to replace all newlines with \n | ||
| return label.components(separatedBy: .newlines).filter { !$0.isEmpty }.joined(separator: " ") |
There was a problem hiding this comment.
To be explicit, theres no prohibition against new lines in accessibility labels. This is a style choice we've made.
There was a problem hiding this comment.
the tests were a good idea! you'll never believe this: they caught a bug (the change up above that i missed)
There was a problem hiding this comment.
Can we move the line into a private category on string in this file now that we have two copies?
|
Thanks for fixing the regression. |
The built in accessibility labels do some mangling of newlines to remove them. Our implementation in `0e9041b4714cac99baa69f4b1b484503868311ba` caused regressions in snapshot and KIF testing.
nsillik
force-pushed
the
nsillik/fix-a11y-newlines-2
branch
from
0b25f8d to
c801e91
Compare
| !links.isEmpty | ||
| else { | ||
| // We need to replace all newlines with " " | ||
| return string.components(separatedBy: .newlines).filter { !$0.isEmpty }.joined(separator: " ") |
There was a problem hiding this comment.
This makes me question where this was happening before...
There was a problem hiding this comment.
Probably the default value coming from UIKit?
There was a problem hiding this comment.
Yup, that's what i think too
There was a problem hiding this comment.
yea, i tested it and it seems to be happening inside UILabel and only occurs when you don't provide an explicit label.
* tag '4.3.0': Prepare version 4.3.0 (#513) Add passThroughTouches to BlueprintView, PassthroughView (#511) Bump checkout and upload-artifacts (#512) Bump rexml from 3.2.8 to 3.3.6 Unnest Box.CornerStyle (#508) Prepare 4.2.1 (#507) Make public the UIBezierPath helper using Box.CornerStyle Prepare 4.2.0 (#505) Label and AttributedLabel now support accessibilityValue (#504) Prepare 4.1.2 Release (#503) Replace newlines in a11y labels with spaces (#502) Fix string index out of bounds crash. (#501) bumping version to 4.1.0 (#499) AttributedLabel Link Accessibility (#459)
The built in accessibility labels do some mangling of newlines to remove them. Our implementation in
0e9041b4714cac99baa69f4b1b484503868311bacaused regressions in snapshot and KIF testing.