Bump Idea to 231.9392.1 (AS Hedgehog) #583
Conversation
hfhbd
force-pushed
the
hfhbd/231.9392.1
branch
from
ad30b68
to
d2368e0
Compare
| @@ -77,8 +89,10 @@ open class SqlCoreEnvironment( | |||
| ProjectRootManager::class.java, | |||
| ProjectRootManagerImpl(projectEnvironment.project), | |||
There was a problem hiding this comment.
Plugin com.squareup.sqldelight:2.1.0-SNAPSHOT-1706283044420 against IC-233.13135.103: 1 compatibility problem. 10 usages of scheduled for removal API and 15 usages of deprecated API. 6 usages of experimental API. 11 usages of internal API
Compatibility problems (1):
#Invocation of unresolved constructor com.intellij.openapi.roots.impl.ProjectRootManagerImpl.<init>(Project)
Constructor com.alecstrong.sql.psi.core.SqlCoreEnvironment.<init>(java.util.List sourceFolders, java.util.List dependencies) contains an *invokespecial* instruction referencing an unresolved constructor com.intellij.openapi.roots.impl.ProjectRootManagerImpl.<init>(com.intellij.openapi.project.Project). This can lead to **NoSuchMethodError** exception at runtime.
This is not compatible with 2023.3.3. Maybe this will work
There was a problem hiding this comment.
we may want to consider moving the Environment types to their own module that doesn't get checked for intellij compatibility - since its only used by the compiler we know what version its on so don't have to worry about forwards compatibility
There was a problem hiding this comment.
we did the same in sqldelight by moving the environment stuff to the gradle plugin so it wouldn't be checked: https://github.com/cashapp/sqldelight/blob/master/sqldelight-gradle-plugin/src/main/kotlin/app/cash/sqldelight/core/SqlDelightEnvironment.kt
There was a problem hiding this comment.
So what's next? Should I move it to another module or do we just ignore it?
There was a problem hiding this comment.
can you move it to another module? maybe :compiler and then we just add that as a dependency of the gradle plugin
There was a problem hiding this comment.
Oh, I named it environment. What do you prefer?
AGP 8.2 is finally released 🎉