Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 550 Insert Select expr #554

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

griffio
Copy link
Contributor

@griffio griffio commented Aug 18, 2023

Split the optional AS rule - the existing grammar was not matching

fixes #550

TODO Tests ( I would need to create tests for specific dialects that support RETURNING) -
as this SQL is only valid on Sqlite 3.37( + higher) and PostgreSql

INSERT INTO answers(id, answer)
SELECT 42, 'forty two'
RETURNING *;

Split the optional AS rule
@griffio griffio marked this pull request as ready for review August 18, 2023 15:49
@griffio griffio changed the title Fix Insert Select expr Fix 550 Insert Select expr Aug 26, 2023
@AlecKazakova AlecKazakova merged commit 5a493a1 into sqldelight:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlite and PostreSql - INSERT INTO ... SELECT ... RETURNING * fails to compile
2 participants