Support synthesized and virtual tables #529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
commented
Jul 3, 2023
| val name: String, | ||
| val content: String, | ||
| ) { | ||
| val fileName = "___predefined/$name" |
There was a problem hiding this comment.
Added because we could clash with user defined file names and we check the file name if we need to use the base package name in sqldelight. This isn't a real solution, but a doable and easy workaround.
There was a problem hiding this comment.
Maybe we could exclude the file from the file index instead? Or somehow create a temp file/remove the virtual file but keep the PsiElement?
hfhbd
force-pushed
the
hfhbd/synthesizedTables
branch
from
18dc9af to
9ebccb1
Compare
hfhbd
changed the title
|
I always get a plugin validation error: Fixed by removing the default values of the interface. |
|
Superseded by #548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed the package name from the predefined table class because we don't use them in sqldelight anymore.