include offending line information for template encoding issues #334
Conversation
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 27cb5ee of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 27cb5ee: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2987 |
| # line but does not show the exact line. | ||
| try: | ||
| for idx in range(0, len(self.data)): | ||
| _content = self.delim.join(list(self.data)[0:idx+1]) |
There was a problem hiding this comment.
you can do list(self.data) before the loop.
Also why not using a binary search?
There was a problem hiding this comment.
Also why not using a binary search?
this is probably overkill for what this code aims to do, so nevermind that :)
| "Exception raised on template line %s:" % (idx), | ||
| exc | ||
| ) | ||
| raise |
| for idx in range(0, len(self.data)): | ||
| _content = self.delim.join(list(self.data)[0:idx+1]) | ||
| # this should never happen | ||
| return _content |
There was a problem hiding this comment.
Maybe it could instead do nothing here and raise the original exception outside the inner try/except
|
mike bayer (zzzeek) wrote: moved to main View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2987 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2987 has been abandoned. That means that at least for the moment I need to close this pull request. Sorry it didn't work out :( |
|
At @jvanasco 's suggestion, I'm closing this in favour of a Python 3-only approach. |
|
Michael Bourke (bourke) wrote: Abandoned in favor of #3406 View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/3142 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/3142 has been abandoned. That means that at least for the moment I need to close this pull request. Sorry it didn't work out :( |
Initial idea to handle #333 .
This caught me when we had to backport some new templates written for staging (Py3) to production (Py2). It should catch similar encoding issues on PY3 as well.