Fix get_x_arguments(as_dictionary=True) for args without =
#1370
Conversation
iurisilvio
force-pushed
the
get-x-arg-without-value
branch
3 times, most recently
from
7c5ded8
to
0c5c395
Compare
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 0c5c395 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 0c5c395: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 18e89e2 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 18e89e2 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
great, needs a changelog file and versionchanged note where documented, then it can go in. thanks!
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision d6cc71c of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset d6cc71c added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
code review left on gerrit
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989
|
Michael Bayer (zzzeek) wrote: also 1.13.1 at this point, 1.13.0 was just released since it had some overdue fixes View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 |
|
All done! |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 8476673 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 8476673 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 |
There was a problem hiding this comment.
Michael Bayer (zzzeek) wrote:
OK just the changelog file and we should be done , thanks
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989
… without `=`
…or args without `=`
…rue)` for args without `=`
…onary=True)` for args without `=`
…s_dictionary=True)` for args without `=`
…ments(as_dictionary=True)` for args without `=`
iurisilvio
force-pushed
the
get-x-arg-without-value
branch
from
8476673
to
830a690
Compare
|
Changelog added! |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 830a690 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset 830a690 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4989 has been merged. Congratulations! :) |
Fix #1369
Description
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!