This repository has been archived by the owner on Sep 8, 2018. It is now read-only.
added isDST and getAbbreviation to TimeZoneTime #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Just found this lib and I love it.
I am a timezone-js refugee, I hope I can find asylum here.
Wanted to add a couple of methods that I need.
Let me know if this contribution should be done in a different way; I will gladly update it.
My editor ate some trailing whitespace (LMK if that is a problem), I would recommend adding a lint rule to forbid them.
Also, what is the point of
WallTimeDate
? It seems like an unused (and wrong, see line 103) duplicate ofTimeZoneTime
, should it be removed?Best regards,
Vadim