apply some code review changes

springdoc · May 5, 2020 · 4ca4dce · 4ca4dce
1 parent 0aecf53
commit 4ca4dce
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/...c-openapi-common/src/main/java/org/springdoc/core/converters/ModelConverterRegistrar.java b/...c-openapi-common/src/main/java/org/springdoc/core/converters/ModelConverterRegistrar.java
@@ -40,14 +40,9 @@ public ModelConverterRegistrar(List<ModelConverter> modelConverters) {
 		for (ModelConverter modelConverter : modelConverters) {
 			Optional<ModelConverter> registeredConverterOptional = getRegisteredConverterSameAs(modelConverter);
 
-			if (!registeredConverterOptional.isPresent()) {
-				ModelConverters.getInstance().addConverter(modelConverter);
-			} else {
-				registeredConverterOptional.ifPresent(alreadyRegisteredModelConverter -> {
-					ModelConverters.getInstance().removeConverter(alreadyRegisteredModelConverter);
-					ModelConverters.getInstance().addConverter(modelConverter);
-				});
-			}
+			ModelConverters modelConvertersInstance = ModelConverters.getInstance();
+			registeredConverterOptional.ifPresent(modelConvertersInstance::removeConverter);
+			modelConvertersInstance.addConverter(modelConverter);
 		}
 	}