Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the usage of JacksonMongoSessionConverter to prevent duplica… #3187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize the usage of JacksonMongoSessionConverter to prevent duplica… #3187

wants to merge 1 commit into from

Conversation

xiaoquanidea
Copy link

…te MongoSession Document saves when a custom ObjectMapper is provided.#3185

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 3, 2024
@xiaoquanidea
Copy link
Author

@vpavic

@marcusdacoregio marcusdacoregio mentioned this pull request Sep 4, 2024
Open
rwinch
rwinch requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Generally, please only make the changes necessary (e.g. no changing of scopes or import ordering), ensure the build passes.

Also this PR should be based off of main since it is a new feature.

...ngodb/src/main/java/org/springframework/session/data/mongo/JacksonMongoSessionConverter.java Outdated Show resolved Hide resolved
@xiaoquanidea
Optimize the usage of JacksonMongoSessionConverter to prevent duplica…
ff90e4e 
…te MongoSession Document saves when a custom ObjectMapper is provided.spring-projects#3185
@xiaoquanidea xiaoquanidea changed the base branch from 3.3.x to main October 22, 2024 06:20
@xiaoquanidea
Copy link
Author

Thanks for the PR. Generally, please only make the changes necessary (e.g. no changing of scopes or import ordering), ensure the build passes.

Also this PR should be based off of main since it is a new feature.

Thank you for the reminder. I have resubmitted the code as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch requested changes

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoquanidea @rwinch @spring-projects-issues