Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary info logs to analyse flaky test issue #561 #597

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

KartikShrivastava
Copy link
Contributor

Why do we need this change?

Due to flakiness of ReactivePulsarListenerTombstoneTests$SingleComplexPayload test, CI PR worflow has been failing intermetently. The exact reason of this flaky behaviour is not known so this PR adds an info log to give more insights on state of receivedMessagesWithHeaders before it is asserted.

What does it do?

  • Updates spring-pulsar-reactive/src/test/resources/logback-test.xml by change log level of ReactivePulsarListenerTombstoneTests$SingleComplexPayload to info
  • Adds an info log in ReactivePulsarListenerTombstoneTests$SingleComplexPayload$shouldReceiveMessagesWithTombstone test

@onobc onobc merged commit 57fa9e2 into spring-projects:main Mar 4, 2024
5 checks passed
@onobc
Copy link
Collaborator

onobc commented Mar 4, 2024

Thanks @KartikShrivastava ,
It is merged - now we just have to sit and wait for it to fail again lol.

@KartikShrivastava KartikShrivastava deleted the analyse-flaky-test branch March 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants