#1047 - Properly respond to application/json calls. #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring HATEAOS must be strict in what it registers, thus NOT use WebFlux's defaults. Yet it should register at least it's HAL-based media types for application/json, the default type used by testing toolkits such as WebTestClient. That way, if you craft a controller that does not deal with hypermedia, it will function as expected. That is why I've expanded HypermediaMappingInformation to include a `getRegisterableMediaTypes` method. By default, it simply returns the results of `getMediaTypes`. But certain media types, like HAL and HAL-FORMS, can add `application/json` as a media type they will respond to if asked. This provides the means to support other formats using the same serializers.
|
I'd love to get on a quick call with @rstoyanchev this week to discuss this approach. My first reaction towards the solution was rather conservative as I am not sure we want to expose this problem in the SPI as to me it seems like a end user decision which of the JSON-based media types is supposed to be the one to be returned for a request asking for |
odrotbohm
force-pushed
the
main
branch
3 times, most recently
from
2e02d7a
to
856b6b9
Compare
odrotbohm
force-pushed
the
main
branch
4 times, most recently
from
5828e78
to
e643c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring HATEAOS must be strict in what it registers, thus NOT use WebFlux's defaults. Yet it should register at least it's HAL-based media types for application/json, the default type used by testing toolkits such as WebTestClient. That way, if you craft a controller that does not deal with hypermedia, it will function as expected.
That is why I've expanded HypermediaMappingInformation to include a
getRegisterableMediaTypesmethod. By default, it simply returns the results ofgetMediaTypes. But certain media types, like HAL and HAL-FORMS, can addapplication/jsonas a media type they will respond to if asked. This provides the means to support other formats using the same serializers.