Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version update happens in transaction with insert. #687

Closed
wants to merge 1 commit into from

Conversation

mat3e
Copy link
Contributor

@mat3e mat3e commented Aug 23, 2024

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

When reading this article, I realized transaction might be missed and party hat Toy can get inserted even when later Minion version update throws OptimisticLockingFailureException. Test confirmed that, so I added transaction handling with annotation.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 23, 2024
schauder pushed a commit that referenced this pull request Aug 23, 2024
@schauder
Copy link
Contributor

Good catch. Thank you. That is merged.

@schauder schauder closed this Aug 23, 2024
@schauder schauder self-assigned this Aug 23, 2024
@schauder schauder added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 23, 2024
@mat3e mat3e deleted the issue/selectiveupdates-tx branch August 23, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants