Add tests for keyless auth to Azure Search vector store #1683
+49
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgotteiner
commented
Nov 6, 2024
mattgotteiner
commented
- Add test validating DefaultAzureCredential can be used with the Azure Search vector store
- Fix filter tests on Windows due to differences in checked-in newlines vs. platform-specific newline.
- Adds dependencies on azure-core, azure-identity, and azure-json packages
markpollack
reviewed
Nov 6, 2024
| @@ -300,6 +301,14 @@ public static class Config { | |||
|
|
|||
| @Bean | |||
| public SearchIndexClient searchIndexClient() { | |||
| // Only set AZURE_AI_SEARCH_TEST_KEYLESS if role-based authentication is set up correctly on the integration service | |||
| // https://learn.microsoft.com/azure/search/search-security-rbac | |||
| if (System.getenv("AZURE_AI_SEARCH_TEST_KEYLESS").equals("true")) { | |||
There was a problem hiding this comment.
I believe we should add some sort of useKeyless or similar name to AzureVectorStoreProperties rather than hard coding a search for an environment variable. Boot will be able to support getting this value from an env-var as well as lots of other places.
|
much appreciated! See comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.