Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve extensibility of SimpleVectoreStore #1662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve extensibility of SimpleVectoreStore #1662

wants to merge 1 commit into from
+73 −61

Conversation

jxblum
Copy link
Contributor

@jxblum jxblum commented Nov 4, 2024 •
edited
Loading

Additionally:

  • Throw IllegalArgumentException instead of NullPointerException from constructor for null EmbeddingModel.
  • Delegate Documentation embedding generation to embed(:Document) method called by doAdd(:Document).
  • Break doSimilaritySearch(:SearchRequest) method into discrete, overridable operations.
  • Implement load(:File) in terms of load(:Resource) using a FileSystemResource.
  • Hide implementation details of EmbeddedMath dotProduct(..) and norm(..) methods.
  • Use more meaningful and descriptive variable names.
  • Simplify Exception handling in save(:File).
  • Add whitespace to improve readability.
  • Fix compiler warnings.

jxblum added a commit to jxblum/spring-ai that referenced this pull request Nov 4, 2024
@jxblum
Improve extensibility of SimpleVectoreStore
ad9e03a 
Additionally:

* Throw IllegalArgumentException instead of NullPointerException from constructor for null EmbeddingModel.
* Delegate Documentation embedding generation to embed(:Document) method called by doAdd(:Document).
* Break doSimilaritySearch(:SearchRequest) method into discrete, overridable operations.
* Implement load(:File) in terms of load(:Resource) using a FileSystemResource.
* Hide implementation details of EmbeddedMath dotProduct(..) and norm(..) methods.
* Use more meaningful and descriptive variable names.
* Add whitespace to improve readability.
* Fix compiler warnings.

Closes spring-projects#1662
@jxblum
Improve extensibility of SimpleVectoreStore
6d22dd4 
Additionally:

* Throw IllegalArgumentException instead of NullPointerException from constructor for null EmbeddingModel.
* Delegate Documentation embedding generation to embed(:Document) method called by doAdd(:Document).
* Break doSimilaritySearch(:SearchRequest) method into discrete, overridable operations.
* Implement load(:File) in terms of load(:Resource) using a FileSystemResource.
* Hide implementation details of EmbeddedMath dotProduct(..) and norm(..) methods.
* Use more meaningful and descriptive variable names.
* Simplify Exception handling in save(:File).
* Add whitespace to improve readability.
* Fix compiler warnings.

Closes spring-projects#1662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxblum @markpollack