-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp/945 decouple sbm support rewrite from maven #946
Merged
fabapp2
merged 14 commits into
version/revamp
from
revamp/945-decouple-sbm-support-rewrite-from-maven
Sep 28, 2023
Merged
Revamp/945 decouple sbm support rewrite from maven #946
fabapp2
merged 14 commits into
version/revamp
from
revamp/945-decouple-sbm-support-rewrite-from-maven
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace MavenProject - Provide Analyzer for order and test - Missing: Maven plugin order and tests
* Moved all Maven related classes not required by RewriteProjectParser to test * Set Maven dependencies to test scope where possible
* Adjust code to missing dependencies previously transitively available
* Adjust code to missing dependencies previously transitively available
fabapp2
deleted the
revamp/945-decouple-sbm-support-rewrite-from-maven
branch
September 28, 2023 21:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project builds and tests are green.
The dependency on Maven classes that require
File
and thus file system access has been removed.The order of Maven projects is calculated in
MavenProjectAnalyzer
.It creates the same result as the previously used Maven classes.
Maven plugins and plugin dependencies are currently ignored.
However, the classpath resolution for multi-module projects is broken.
Correct classpath resolution will also allow fixing #879 and #871.
Related open tasks: