Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp/997 example of iterative upgrade #1001

Draft
wants to merge 9 commits into
base: version/revamp
Choose a base branch
from
Draft

Revamp/997 example of iterative upgrade #1001

wants to merge 9 commits into from

Conversation

fabapp2
Copy link
Contributor

@fabapp2 fabapp2 commented Nov 20, 2023 •
edited
Loading

The example uses sbm-support-rewrite parser and sequentially upgrades a given repo.

  1. A given repo gets cloned
  2. The version from the <parent> section of the pom.xml is extracted
  3. A matching upgrade recipe is looked up and applied
  4. The result is committed on a new branch and the changes get pushed
  5. A new PR with the changes of the upgrade is created
  6. The process stops until the PR is merged
  7. Go to 1

@fabapp2 fabapp2 linked an issue Nov 20, 2023 that may be closed by this pull request
Example of iterative upgrade from PetClinic 2.6 to 3.0 #997
Open
@fabapp2 fabapp2 changed the base branch from main to version/revamp November 20, 2023 16:31
@fabapp2 fabapp2 self-assigned this Nov 20, 2023
@fabapp2 fabapp2 added in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent type: demo labels Nov 20, 2023
@fabapp2
Copy link
Contributor Author

fabapp2 commented Nov 20, 2023

MavenArtifactDownloader should interpret relocations

The upgrade in #1001 fails from 2.5 to 2.6

org.openrewrite.maven.MavenDownloadingException: mysql:mysql-connector-java failed. Unable to download dependency mysql:mysql-connector-java:8.0.33. Response was 404

mysql:mysql-connector-java:8.0.33 is a relocation release and the MavenArtifactDownloader fails to download it.

The pom
MySQL Connector Metadata

@fabapp2 fabapp2 mentioned this pull request Nov 20, 2023
Open
@fabapp2 fabapp2 force-pushed the revamp/997-example-of-iterative-upgrade branch from 367c4e9 to e3b15f4 Compare November 21, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabapp2 fabapp2

Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent type: demo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example of iterative upgrade from PetClinic 2.6 to 3.0
1 participant
@fabapp2