-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating a Kotlin project with a package name containing keywords will result in an unusable project #1555
Conversation
Hey, thanks for the PR. I think there's something missing: i just tested with the package name
I think the code in |
Thank you. I'm not sure if it is ok to just add a parameter |
Thank you very much and congratulations on your first contribution 🎉! I've polished the changes a bit in bce08cf. |
fix #1550
Initializer does not escape package names containing kotlin keywords, and generates unusable project. This fix checks for hard keywords (from offcial doc, Kotlin does not provide method like
javax.lang.model.SourceVersion#isKeyword
in Java)