Add Spring Boot Docker Compose support #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures a lot of the guide to use Spring Boot Docker Compose support. They key teachings of the guide remain the same, however a lot of the upfront tasks, such as creating the MySQL database and the
application.properties
file, are no longer at the beginning of the guide. These tasks are no longer required, which should allow the user to get started with the code faster than before.There are a few specific items in this PR that I would like a further review on:
initial
folder. This test does not exist at all in thecomplete
folder. I addedTestcontainers
to the project so that the context loads and these tests pass. The test now exists in thecomplete
andinitial
folders.Building the Application
section, I am using the Docker feature for container networks so that all of my containers can communicate with one another. Is this the best practice? I also had to add a third container to test the application, as specified in the newTest the Application in Docker
section.as I received an error from Hibernate at runtime. If native does not work with no custom hints, I think it is best not to add that complexity. Still, I find it interesting native did not work out of the box so it could be something I am doing wrong.(Update: native compilation now works with this guide, when using the0.10.2
version of the Gradle plugin)Hoping that @mp911de and @mhalbritter can take a look.
Addresses issue #60