-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spring Boot Docker Compose support #61
Add Spring Boot Docker Compose support #61
Conversation
…e Boot 3.3, maven and gradle wrapper, docker compose, testcontainers
…r compose support, added test class
Hey Bob, thanks for your work! I've added some comments, but they are only minor things. |
Regarding the common file:
compose.yml should be in backticks,
I'd add backticks: Call
I'd add backticks: Call |
The current guide instructs the user to run a command docker-compose but the more recent version of the command is docker compose.
|
||
== Test the Application in Docker | ||
|
||
If you ran the application using a Docker instruction above, a simple curl command from a terminal or command line will no longer work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "a Docker instruction above" to "the Docker instruction shown earlier"
This PR restructures a lot of the guide to use Spring Boot Docker Compose support. They key teachings of the guide remain the same, however a lot of the upfront tasks, such as creating the MySQL database and the
application.properties
file, are no longer at the beginning of the guide. These tasks are no longer required, which should allow the user to get started with the code faster than before.There are a few specific items in this PR that I would like a further review on:
initial
folder. This test does not exist at all in thecomplete
folder. I addedTestcontainers
to the project so that the context loads and these tests pass. The test now exists in thecomplete
andinitial
folders.Building the Application
section, I am using the Docker feature for container networks so that all of my containers can communicate with one another. Is this the best practice? I also had to add a third container to test the application, as specified in the newTest the Application in Docker
section.as I received an error from Hibernate at runtime. If native does not work with no custom hints, I think it is best not to add that complexity. Still, I find it interesting native did not work out of the box so it could be something I am doing wrong.(Update: native compilation now works with this guide, when using the0.10.2
version of the Gradle plugin)Hoping that @mp911de and @mhalbritter can take a look.
Addresses issue #60