feat: Multi-AZ Failover LoadBalancing #1212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
requested changes
Mar 7, 2023
...c/main/java/org/springframework/cloud/loadbalancer/config/LoadBalancerAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/cloud/loadbalancer/config/LoadBalancerAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/cloud/loadbalancer/config/LoadBalancerAutoConfiguration.java
Outdated
Show resolved
Hide resolved
kworkbee
force-pushed
the
loadbalancer/multi-az-failover
branch
from
fb5a2fb
to
481305c
Compare
|
Any progress with this? @spencergibb |
|
No. Please be patient |
|
It's a big change. The earliest it would be merged would be when we start the 2023.0 release train (4.1.0 of spring cloud commons). We won't even start that until June. |
|
Thanks for your answer. I'll consider this, and if any corrections needed please feel free to mention me. |
…be added into cache
|
Updated feature: Instances will be added into a cache only when connection fails or 5xx error occurs. 4xx Errors will not be triggered. |
- assertNull -> assertThat.isNull
|
Hi, @spencergibb @OlgaMaciaszek Still needs to be reviewed? |
|
Hi @kworkbee, sorry, this feature didn't make it to the planned backlog for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a multi-AZ environment, a loadbalancer looks at
ServiceInstances of the primary zone first, but when the instances of that are not connected correctly, then it looks at the instances of the secondary zones.What's changed
spring.cloud.loadbalancer.configurations: multi-az-failover: It enablesMultiAZFailoverServiceInstanceListSupplier.spring.cloud.loadbalancer.secondary-zones: A,B,C: Secondary Zones.To use this feature, Caching must be needed to record
ServiceInstancesinto a cache for remembering connection-failed instances.MultiAZFailoverServiceInstanceListSupplierwill calculate available instances by comparing those in cache.Issues
Related to #1203