Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviews settings ability #162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/models/spree/reviews_ability.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,18 @@ class Spree::ReviewsAbility

def initialize(user)
review_ability_class = self.class

can :create, Spree::Review do
review_ability_class.allow_anonymous_reviews? || !user.email.blank?
end

can :create, Spree::FeedbackReview do
review_ability_class.allow_anonymous_reviews? || !user.email.blank?
end

if user.respond_to?(:has_spree_role?) && user.has_spree_role?('admin')
can :manage, Spree::ReviewSetting
end
end

def self.allow_anonymous_reviews?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
virtual_path: 'spree/admin/shared/sub_menu/_configuration',
name: 'converted_admin_configurations_menu',
insert_bottom: '[data-hook="admin_configurations_sidebar_menu"]',
text: '<%= configurations_sidebar_menu_item Spree.t(:review_settings, scope: :spree_reviews), edit_admin_review_settings_path %>'
text: '<%= configurations_sidebar_menu_item(Spree.t(:review_settings, scope: :spree_reviews), edit_admin_review_settings_path) if can?(:manage, Spree::ReviewSetting) %>'
)
16 changes: 16 additions & 0 deletions spec/models/reviews_ability_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,20 @@
end
end
end

describe 'access review settings' do
subject { described_class.new(user) }

context 'when is ordinal user' do
let(:user) { build_stubbed(:user) }

it { is_expected.not_to be_able_to(:manage, Spree::ReviewSetting) }
end

context 'when is admin' do
let(:user) { build_stubbed(:admin_user) }

it { is_expected.to be_able_to(:manage, Spree::ReviewSetting) }
end
end
end
2 changes: 1 addition & 1 deletion spree_reviews.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'database_cleaner'
s.add_development_dependency 'poltergeist'
s.add_development_dependency 'rspec-rails'
s.add_development_dependency 'factory_girl'
s.add_development_dependency 'factory_bot'
s.add_development_dependency 'sqlite3'
s.add_development_dependency 'simplecov'
s.add_development_dependency 'coffee-rails'
Expand Down