This repository has been archived by the owner on Nov 28, 2021. It is now read-only.
Set tls:true if secure_connection #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 6, 2017
| settings.merge({ | ||
| enable_starttls_auto: true, | ||
| tls: true | ||
| }) |
There was a problem hiding this comment.
Indent the right brace the same as the first position after the preceding left parenthesis.
| settings.merge enable_starttls_auto: secure_connection? | ||
| if secure_connection? | ||
| settings.merge({ | ||
| enable_starttls_auto: true, |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
| @@ -19,7 +19,12 @@ def mail_server_settings | |||
| basic_settings | |||
| end | |||
|
|
|||
| settings.merge enable_starttls_auto: secure_connection? | |||
| if secure_connection? | |||
| settings.merge({ | |||
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #35