Void and Cancel methods added. They use a "refund" to accomplish thei… #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r behaviour. Works for partially refunded payments as well.
tomfarm
added a commit
to formrausch/better_spree_paypal_express
that referenced
this pull request
Jan 5, 2016
|
Has this been merged into 3-0-stable? |
|
Any updates on this? I was about to work on this as we are running into the same issue |
| end | ||
| end | ||
|
|
||
| empty_success |
There was a problem hiding this comment.
This appears to return successfully even if the refund transaction fails. Is that the intended behavior?
There was a problem hiding this comment.
Likely not, but frankly I haven't touched this code since so I'm not even sure either way. You're going to have to test it out and see what happens.
|
As I mentioned, I haven't touched this stuff since the PR (actually haven't even worked on a spree project since then), so it's safe to say that no active dev is being done one this (at least by me). This did work fine for several cases when I wrote it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r behaviour.
Works for partially refunded payments as well.
Fixes #169 and #171