Important fixes for VAT-included stores [2-3-stable] #139
+130
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable paypal payments for stores with VAT-included prices (very common in the EU) and should finally solve #129 and #17.
The first fix was already included in
2-2-stable
, this just adds a regression spec.The second one it's a kind of workaround because paypal does not accept negative taxes amounts.
But this is very important because on Spree we have negative taxes when a country without VAT buys from a VAT-included store, like in this example:
This is also including all the commits from #138 to get green specs.