Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spree/PayPal Address Preferences #128

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

fredjean
Copy link
Contributor

Addresses concerns raised in #113 by allowing the store administrator to decide how addresses are presented and handled.

Allows the store administrator to:

  • Display the shipping address on PayPal
  • Override the address stored in PayPal
  • Require a confirmed shipping address from PayPal.

Also contains code that adjusts the feature specs based on which layout is provided by PayPal.

The goal of this is to give a store operator the tools needed to be able to
place seller protection elibible payments against Paypal.

The changes are:

* Creating a no_shipping preference to give the store developer a say in whether to send the shipping address. (spree-contrib#113)
* Adds the ability to send a shipping address to Paypal (see spree-contrib#113)
* Adds the option of displaying the shipping address on the Paypal pages.
* Upgrades the Paypal SDK gem
* Adds the ability to request a confirmed shipping address from Paypal.
* Extracts the confirmed address from the Paypal express checkout details when
  we are configured to require a confirmed shipping address.
Pushing to the branch is the only way I have to retry the specs on travis-ci.
@rposborne
Copy link

What's the status of this pull?

@fredjean
Copy link
Contributor Author

It was ready to merge a long, long time ago... I'm fine bringing the code up to date and address the merge issues to get it back to a state where it can be merged if there's still interest in it.

@tnj
Copy link

tnj commented Mar 29, 2015

Thank you for your work @fredjean! 🍻 I'm wondering why is this PR not merged yet.

@joeswann
Copy link

joeswann commented Jun 24, 2016

Just ran hard into this exact issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants