add cicd files for v2 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ImpSy <[email protected]>
Z4ck404
reviewed
Oct 23, 2024
| run: | | ||
| make generate | ||
| if ! git diff --quiet; then | ||
| echo "Need to re-run 'make generate' and commit the changes." |
There was a problem hiding this comment.
nit: I don't see this target in the make file above ?
There was a problem hiding this comment.
this comes from base makefile and it's just a copy of what is in integration.yaml
Z4ck404
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-5296
Description
Description of the work contained in this PR
Demo
Please add a recording/screenshot of the feature/bug fix in work
Checklist
How to test
Description of environment setup necessary to exercise the feature and perform tests
Test plan and results
Feel free to add screenshots showing test results