Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Make datastore emulator tests work locally #1042

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sonjaer
Copy link
Contributor

@sonjaer sonjaer commented Mar 6, 2023

Hey, I just made a Pull Request!

Description

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@sonjaer sonjaer marked this pull request as ready for review March 6, 2023 15:35
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1042 (0db0394) into master (a257d29) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1042      +/-   ##
============================================
- Coverage     91.29%   91.25%   -0.04%     
+ Complexity     2111     2110       -1     
============================================
  Files           199      199              
  Lines          8269     8270       +1     
  Branches        501      502       +1     
============================================
- Hits           7549     7547       -2     
- Misses          600      602       +2     
- Partials        120      121       +1     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant