Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get and list workflows from github actions API #197

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

hvardhanx
Copy link
Contributor

@hvardhanx hvardhanx commented Sep 17, 2024

Hi @Abhi347!

Here is a small PR which adds get and list workflows from Github Actions API:

Added tests as well for code coverage

@hvardhanx
Copy link
Contributor Author

@ebk45 a small ping for review 🙂

ebk45
ebk45 previously requested changes Oct 3, 2024
Copy link
Contributor

@ebk45 ebk45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this client looks great, it would be appreciated if you could follow the existing nesting pattern we have established that follows the GitHub API. In this case, you'd need to create a parent ActionsClient and then your WorkflowsClient can be instantiated from there.

There's many examples of this around the codebase, for instance here issues are nested under repos, so you create an issue client from a repo client: https://github.com/spotify/github-java-client/blob/master/src/main/java/com/spotify/github/v3/clients/RepositoryClient.java#L119

@hvardhanx
Copy link
Contributor Author

Thank you so much for the review @ebk45! I have updated the pull request and added ActionsClient under RepositoryClient and WorkflowsClient is now a child of ActionsClient. Please let me know if I need to change anything. 🙂

@hvardhanx
Copy link
Contributor Author

small ping for review @ebk45 🙂

@dennisgranath dennisgranath dismissed ebk45’s stale review October 21, 2024 10:48

Out of office for the coming 6 months

@dennisgranath dennisgranath merged commit fbcd82c into spotify:master Oct 21, 2024
3 checks passed
@hvardhanx
Copy link
Contributor Author

Thanks a lot! @dennisgranath 😄

@hvardhanx hvardhanx deleted the hx/add-ga-workflows branch October 21, 2024 11:05
@hvardhanx
Copy link
Contributor Author

hvardhanx commented Oct 21, 2024

Adds ActionsClient for #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants