-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get and list workflows from github actions API #197
Conversation
@ebk45 a small ping for review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this client looks great, it would be appreciated if you could follow the existing nesting pattern we have established that follows the GitHub API. In this case, you'd need to create a parent ActionsClient
and then your WorkflowsClient
can be instantiated from there.
There's many examples of this around the codebase, for instance here issues are nested under repos, so you create an issue client from a repo client: https://github.com/spotify/github-java-client/blob/master/src/main/java/com/spotify/github/v3/clients/RepositoryClient.java#L119
Thank you so much for the review @ebk45! I have updated the pull request and added |
small ping for review @ebk45 🙂 |
Out of office for the coming 6 months
Thanks a lot! @dennisgranath 😄 |
Adds ActionsClient for #18 |
Hi @Abhi347!
Here is a small PR which adds get and list workflows from Github Actions API:
Added tests as well for code coverage