fix: Fix warnings and prevent potential issues #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
fabriziodemaria
force-pushed
the
fix-warnings
branch
from
ec90234
to
f831167
Compare
fabriziodemaria
force-pushed
the
fix-warnings
branch
from
f831167
to
136e5a8
Compare
fabriziodemaria
changed the title
nicklasl
reviewed
Nov 5, 2024
nicklasl
approved these changes
Nov 5, 2024
| @@ -123,7 +123,12 @@ final class EventSenderEngineImpl: EventSenderEngine { | |||
| } | |||
|
|
|||
| func withSemaphore(callback: @escaping () async -> Void) async { | |||
| semaphore.wait() | |||
| await withCheckedContinuation { continuation in | |||
There was a problem hiding this comment.
Not fully sure if this is a no-op change or not?
There was a problem hiding this comment.
it should behave the same way, just removes a warning (and apparently being a safer approach against deadlocks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some changes suggested by the static linter.
Suggestion is to review commit by commit