Try send stored apply events on init #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
reviewed
Jul 26, 2023
| @@ -40,6 +40,14 @@ class EventProcessor<INPUT, BatchProcessInputs, DATA>( | |||
| // ensures we don't have any shared mutability | |||
| val data: DATA = onInitialised() | |||
|
|
|||
| // Try send events retrieved via "onInitialised()" | |||
| onProcessBatch( | |||
There was a problem hiding this comment.
do we check already if the data is empty? i suppose we do it already in the onProcessBatch?
There was a problem hiding this comment.
Yes exactly, data is filtered for valid events to send otherwise nothing happens
vahidlazio
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than being good for delivering events faster and more reliably, this PR also aligns this Provider's init behaviour closer with the Swift Provider