fix: Fix the bug regarding accessing flags using with context #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
requested review from
fabriziodemaria,
nicklasl and
nickybondarenko
as code owners
| @@ -144,7 +146,7 @@ class Confidence internal constructor( | |||
| it.getContext().filterKeys { key -> !removedKeys.contains(key) } + contextMap.value | |||
| } ?: contextMap.value | |||
|
|
|||
| override fun withContext(context: Map<String, ConfidenceValue>): Confidence = Confidence( | |||
| override fun withContext(context: Map<String, ConfidenceValue>): ConfidenceAPI = Confidence( | |||
There was a problem hiding this comment.
The EventSender interface already extends Contextual: can we just return the EventSender type from withContext?
There was a problem hiding this comment.
I think we can good point.
nickybondarenko
approved these changes
Jul 1, 2024
nicklasl
approved these changes
Jul 1, 2024
fabriziodemaria
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.